F-Droid can't build

[licaon-kter]

ref: https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.you/123#site-footer

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/12f595f7a9fd91dbbc9b8f6f088e153d283c6788

[TotallyAvailable]

Given

< 	<item drawable="google_chrome" />
---
> 	<item drawable="goole_chrome" />

The 8.2.0 currently available is not the 8.2.0 that first got released.

ref
#1836 (comment)
#1836 (comment)

[licaon-kter]

The 8.2.0 currently available is not the 8.2.0 that first got released.

The current one (Nov 25) was compared against and failed.

The "first" one was released when?

[licaon-kter]

I guess we'll get the update soon? 322ccc1#diff-97fdc17bceb48025fc60d20f4e9ba07c1c3d4c8aaef0c5c0133d3aaf1b106e12 @Donnnno

[Donnnno]

Oh thanks for the notice! Looks like I updated the APK for the reproducible build, but the tag/release stayed the same.

[Donnnno]

This will be fixed by simply releasing a new version, hoping to do that soon!

[licaon-kter]

In theory yes :)

[linsui]

Fixed.

[linsui]

I guess I should also add the dayNight flavor?

[Donnnno]

Fixed.

Fantastic!

[Donnnno]

Fixed

Fantastic!

I guess I should also add the dayNight flavor?

We could! I haven't done it yet because I was thinking that we're polluting F-Droid with all these minimal variations at this point 😅 no idea if people actually will use it 🙃

[TotallyAvailable]

Even with all Arcticons variants you still don't need your toes to count the number of available and updated Icon Packs available on F-Droid.

[linsui]

We could! I haven't done it yet because I was thinking that we're polluting F-Droid with all these minimal variations at this point 😅 no idea if people actually will use it 🙃

I have packaged it. :)

[Donnnno]

Omg amazing! Thank you so much @linsui

[licaon-kter]

aaand again :( https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.you/128#site-footer pls reopen

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/76d108a3c077d5e8e2eef9678428281aca5e2b23

[linsui]

#1952

[Donnnno]

Oh no :(

[TotallyAvailable]

Gone for a couple days and everything is falling appart apparently. Gonna eventually have a look to provide absolutely no helpful comment afterwards.

No but in all seriousness and in regards to #1952

• Both PNG based versions made it through
• Both XML based versions failed
• No hot-fixes causing comparison mismatches

Might be a good idea to just summon @Kaiserdragon2

As it wasn't me who made the Day/Night version happen, a "no helpful comment" would be the best I could give.
"Something is broken and the code is there" doesn't necessarily equal a solution.

[Donnnno]

Just pushed a new release, hopefully it should be fixed now :)

[licaon-kter]

@Donnnno you've tagged https://github.com/Arcticons-Team/Arcticons/releases/tag/9.7.4 from 2a5feaf

but the APK was built from 82420dc ? ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7055233627#L2178

[licaon-kter]

and https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.you/1340#site-footer

and https://monitor.f-droid.org/builds/log/com.donnnno.arcticons/1340#site-footer

and https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.light/1340#site-footer

and https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.daynight/1340#site-footer

[licaon-kter]

https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.you/1350#site-footer

https://monitor.f-droid.org/builds/log/com.donnnno.arcticons/1350#site-footer

https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.light/1350#site-footer

https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.daynight/1350#site-footer

[Donnnno]

oh no, again?!

[Donnnno]

How can we check where it's different? So we can get an idea where it goes wrong?

[licaon-kter]

You mean besides the list of files mentioned in the linked logs? I can build locally, which one do you want?

[Donnnno]

A local build might help to compare the two.
There might be something in the build process that screws it up again? Maybe @Kaiserdragon2 knows what could cause it?

[licaon-kter]

Here are the diff logs: art.tar.gz

or you want the APKs?

[Donnnno]

Ah, I know what the differences are, thank you!

@Kaiserdragon2 the process of adding the contributor images, seems to differ with the android studio build, vs the f-droid build. Sounds like the sorting issue from a while ago.

When we've fixed this, I'll release a fix for F-Droid

[Donnnno]

Update: I've published a new release https://github.com/Arcticons-Team/Arcticons/releases/tag/10.0.5-hotfix

[licaon-kter]

diff -r /tmp/tmp3ajc543x/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/META-INF/version-control-info.textproto /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/META-INF/version-control-info.textproto           4c4                                                        
<   revision: "ff344a25c087d9011c0e5066ec553fdbc3977586"   
---                                                       
 >   revision: "5b2d7f1be261964e596d6bb1ac31b3254179a3ae"  
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_0.png                  Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_4.png                  Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_5.png                  
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_6.png                  Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_7.png
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_8.png
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_9.png
Binary files /tmp/tmp3ajc543x/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/res/IOs.xml and /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/res/IOs.xml differ

Nope :(

Of note, please build the APK from the tagged commit and upload that one to releases, instead of random APKs that you build locally to test before commiting changes.

/LE:L reformatted lof

[Donnnno]

I always build them locally, so I don't get it...

[licaon-kter]

I've reformatted the diff log above so it's clear:

<   revision: "ff344a25c087d9011c0e5066ec553fdbc3977586"   
---                                                       
>   revision: "5b2d7f1be261964e596d6bb1ac31b3254179a3ae"  

means that I built from the tagged 5b2d7f1 while you did it either from ff344a2 or from the tree BEFORE committing the changes in 5b2d7f1

[Donnnno]

Oh, strange. Here we go again then. I've updated the APKs from the release. Hope you can trigger the run again?

[Donnnno]

@licaon-kter can you check if it works? :)

[licaon-kter]

==== detail begin ====
verification of APK with copied signature failed
Comparing reference APK to APK with copied signature...
Unexpected diff output:
Binary files /tmp/tmp14yvzfg5/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/assets/contributors/downloaded/contributor_128.png and /tmp/tmp14yvzfg5/_tmp_tmp14yvzfg5_sigcp_com.donnnno.arcticons_1350/content/assets/contributors/downloaded/contributor_128.png differ
Binary files /tmp/tmp14yvzfg5/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/res/IOs.xml and /tmp/tmp14yvzfg5/_tmp_tmp14yvzfg5_sigcp_com.donnnno.arcticons_1350/content/res/IOs.xml differ
==== detail end ====

from ff344a2

[Donnnno]

10.4.0 should fix everything. We're doing automated building now :)

[licaon-kter]

/LE: looks like there's no need for tricks 🎉

[licaon-kter]

thanks https://gitlab.com/fdroid/fdroiddata/-/commit/c598cee29a7ca0a93cbaf2a77799534f078e96e9

[Donnnno]

Thank you!!
Pfew I started panicing a bit when I saw your previous message. Glad that you were able to solve it! ::)