Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Wait for Manual Approval Conclusions #269

Open
Rd4dev opened this issue Nov 12, 2024 · 2 comments
Open

Request to Wait for Manual Approval Conclusions #269

Rd4dev opened this issue Nov 12, 2024 · 2 comments

Comments

@Rd4dev
Copy link

Rd4dev commented Nov 12, 2024

This is a request to treat action_required not as a conclusion, but instead to pause the workflow and wait for the manual approval conclusion. This approach would ensure that the workflow remains pending until explicit approval is granted, allowing for necessary validations before proceeding.

The reason for this request is that when first-time contributors' PRs require the workflow to be approved and run, the "action-wait-for-workflow" action defined in the pull request target trigger starts running immediately. During the "action-wait-for-workflow" step, it receives an action_required conclusion and proceeds right away. However, it would be more suitable for the step to pause and wait for the manual approval before continuing.

@ArcticLampyrid
Copy link
Owner

I'm still unsure how to handle this situation. In fact, we don't have a way to truly suspend a job and wait for the completion of another workflow (unless Actions offers support for this). Instead, we are just continuously polling the status and sleeping in between checks. For scenarios requiring manual approval, unless you approve the workflow to run in a very short amount of time, even if we wait there, our job is highly likely to be forcibly terminated due to a timeout (or incur excessive costs if you're on a paid plan).

Do you have any good suggestions for this?

@Rd4dev
Copy link
Author

Rd4dev commented Nov 19, 2024

Thanks for responding! I’m also unsure how to handle this, and after discussing it with the team, they suggested opening a discussion in the GitHub Community Discussions. Hopefully, someone there might offer a different approach to resolve this. I’m linking it here to follow along if that helps.

Discussion: https://github.com/orgs/community/discussions/145056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants