You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a request to treat action_required not as a conclusion, but instead to pause the workflow and wait for the manual approval conclusion. This approach would ensure that the workflow remains pending until explicit approval is granted, allowing for necessary validations before proceeding.
The reason for this request is that when first-time contributors' PRs require the workflow to be approved and run, the "action-wait-for-workflow" action defined in the pull request target trigger starts running immediately. During the "action-wait-for-workflow" step, it receives an action_required conclusion and proceeds right away. However, it would be more suitable for the step to pause and wait for the manual approval before continuing.
The text was updated successfully, but these errors were encountered:
I'm still unsure how to handle this situation. In fact, we don't have a way to truly suspend a job and wait for the completion of another workflow (unless Actions offers support for this). Instead, we are just continuously polling the status and sleeping in between checks. For scenarios requiring manual approval, unless you approve the workflow to run in a very short amount of time, even if we wait there, our job is highly likely to be forcibly terminated due to a timeout (or incur excessive costs if you're on a paid plan).
Thanks for responding! I’m also unsure how to handle this, and after discussing it with the team, they suggested opening a discussion in the GitHub Community Discussions. Hopefully, someone there might offer a different approach to resolve this. I’m linking it here to follow along if that helps.
This is a request to treat
action_required
not as a conclusion, but instead to pause the workflow and wait for the manual approval conclusion. This approach would ensure that the workflow remains pending until explicit approval is granted, allowing for necessary validations before proceeding.The reason for this request is that when first-time contributors' PRs require the workflow to be approved and run, the "action-wait-for-workflow" action defined in the pull request target trigger starts running immediately. During the "action-wait-for-workflow" step, it receives an
action_required
conclusion and proceeds right away. However, it would be more suitable for the step to pause and wait for the manual approval before continuing.The text was updated successfully, but these errors were encountered: