Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup #10

Open
Arcterus opened this issue Mar 3, 2017 · 2 comments
Open

Code Cleanup #10

Arcterus opened this issue Mar 3, 2017 · 2 comments

Comments

@Arcterus
Copy link
Owner

Arcterus commented Mar 3, 2017

So, because I didn't know how to use Piston very well when I first wrote this and the code is old af (for Rust code), the code is pretty messy right now. It needs to be cleaned up in a major way.

@linonetwo
Copy link

linonetwo commented Mar 22, 2018

error[E0554]: #![feature] may not be used on the stable release channel
 --> src/life.rs:1:1
  |
1 | #![feature(conservative_impl_trait)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

can you clean up this?

@Arcterus
Copy link
Owner Author

The problem with that is that stuff like this would need to be changed to use Box<Iterator> rather than impl Iterator. It's not too much of an issue I suppose, but it means there would be a lot of unnecessary memory allocations.

In any case, I may change the algorithm entirely as it can get quite slow right now when there are too many blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants