Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basket #11

Open
Spartak-Belov-Floresku opened this issue Oct 15, 2019 · 2 comments
Open

basket #11

Spartak-Belov-Floresku opened this issue Oct 15, 2019 · 2 comments

Comments

@Spartak-Belov-Floresku
Copy link

Spartak-Belov-Floresku commented Oct 15, 2019

Guys, there is an incomplete code for middlewares.py. It collapses all app for a customer, during a testing. I added extra code for the file and now it works. You can find the fixed code here, hope it is going to be a helpful for you.

@Spartak-Belov-Floresku
Copy link
Author

Spartak-Belov-Floresku commented Oct 17, 2019

I have a new update for you guys. Because, I added extra code to the middlewares.py on the row #16. I wrote "del request.session['basket_id']". Now, to avoid a crash of the app we need to remove the same directive from the file views.py on the row #199 or you can use "try - except" block there. Guys, why do you not use "try - except" blocks in the app during critical requests like HTTP or DB? It is going to help us to reduce crash of the app and give us ability to see a more useful information by using messages app.

@aadurham
Copy link

aadurham commented Jan 5, 2020

Thanks for all the hard work, which should have been done by the author at the first place! By the way, the author is of no help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants