AppController revives properly #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of from local state, which is not yet initialized in that case
ghost
assigned 
|
Code looks good. Requires a demo. |
…e same appscale deployment
…t gets backed up and restored via ZooKeeper correctly
…it erroneously detects itself as failed when it revives
nlake44
added a commit
that referenced
this pull request
Jan 2, 2013
…roperly AppController revives properly
|
Demo'ed and works as expected. |
nlake44
added a commit
to nlake44/appscale
that referenced
this pull request
Sep 30, 2013
…m-instances added capability to specify ec2 credentials when running appscale-termin...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services monitored by god are supposed to be revived if they crash. The AppController is monitored by god, and to enable it to revive properly, it periodically writes its state to ZooKeeper. However, issue #33 details a problem where the AppController attempts to read local state in the revival process, and since that data isn't initialized, the AppController fails once again.
This pull request addresses this issue by not reading from the uninitialized local state to get our own node's IP address, and just queries it via
ifconfig.