Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 0.6.1 release artifacts are zipped twice #5623

Closed
aliesbelik opened this issue Jun 25, 2024 · 3 comments
Closed

[Bug] 0.6.1 release artifacts are zipped twice #5623

aliesbelik opened this issue Jun 25, 2024 · 3 comments

Comments

@aliesbelik
Copy link

Bug Description

*.zip artifacts from 0.6.1 release are zipped twice (a zip archive inside another zip archive with the same name),
i.e.

AppFlowy-0.6.1-windows-x86_64.zip
  AppFlowy-0.6.1-windows-x86_64.zip
    AppFlowy
      ...
AppFlowy-0.6.1-macos-x86_64.zip
  AppFlowy-0.6.1-macos-x86_64.zip
    AppFlowy.app
      ...
AppFlowy-0.6.1-macos-universal.zip
  AppFlowy-0.6.1-macos-universal.zip
    AppFlowy.app
      ...

Not the issue for previous releases, including 0.6.0.

How to Reproduce

  1. Go to the 0.6.1 release assests: https://github.com/AppFlowy-IO/AppFlowy/releases/tag/0.6.1.
  2. Download any *.zip, e.g. https://github.com/AppFlowy-IO/AppFlowy/releases/download/0.6.1/AppFlowy-0.6.1-windows-x86_64.zip.
  3. Unpack it somewhere.

Expected Behavior

After unpacking, one would expect to see AppFlowy directory containing the application files.

Operating System

windows

AppFlowy Version(s)

0.6.1

Screenshots

No response

Additional Context

No response

@aliesbelik
Copy link
Author

aliesbelik commented Jun 25, 2024

Looks like there are no recent changes in release.yml that could cause that.
Similar issue reported for upload-artifact GH action (actions/upload-artifact#39) but as far as I see it isn't used here.

@aliesbelik
Copy link
Author

Not reproducible with 0.6.2 release *.zip packages.

@annieappflowy
Copy link
Collaborator

Thank you for confirming that this bug was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants