Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local CLI build fails #1272

Closed
martincostello opened this issue Jun 9, 2023 · 3 comments
Closed

Local CLI build fails #1272

martincostello opened this issue Jun 9, 2023 · 3 comments
Labels
v8 Issues related to the new version 8 of the Polly library.
Milestone
v8.0.0

Comments

@martincostello
Copy link
Member

When building Polly locally and running build.ps1, the build fails due to 67 code analysis errors. These don't seem to be firing in CI or in Visual Studio, so I'm not sure what's going on with the setup that's making that the case.

Either Visual Studio and CI should be failing, or local CLI builds should by-default use the same analyzer configuration.

Build Output 
========================================
__BuildSolutions
========================================
Executing task: __BuildSolutions
Building C:/Coding/App-vNext/Polly/src/Polly.sln
MSBuild version 17.6.1+8ffc3fe3d for .NET
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(10,38): error IDE1006: Naming rule violation:
Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(18,59): error IDE1006: Naming rule violation: Missing prefix: '_
' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(136,26): error S2094: Remove this empty class, write its code or
 make it an "interface". [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\ResilienceStrategyPipeline.cs(70,9): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\RandomUtil.cs(13,5): error IDE0021: Use block body for constructor [C:\Coding\A
pp-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\GeneratorInvoker.cs(21,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\CancellationTokenSourcePool.Disposable.cs(9,9): error IDE0021: Use block body f
or constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(46,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(54,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(63,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(72,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(12,5): error IDE0021: Use block body for const
ructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ScheduledTaskExecutor.cs(14,5): error IDE0021: Use block bo
dy for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ConsecutiveFailuresCircuitBehavior.cs(8,5): error IDE0021:
Use block body for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceStrategy.TResult.Async.cs(13,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(43,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(51,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(19,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(22,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(29,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(22,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(29,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(38,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(52,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Fallback\FallbackHandler.Handler.cs(9,9): error IDE0021: Use block body for construct
or [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
  Polly.Core -> C:\Coding\App-vNext\Polly\src\Polly.Core\bin\Release\net472\Polly.Core.dll
  Polly.Core -> C:\Coding\App-vNext\Polly\src\Polly.Core\bin\Release\netstandard2.0\Polly.Core.dll
  Polly.Core -> C:\Coding\App-vNext\Polly\src\Polly.Core\bin\Release\net6.0\Polly.Core.dll
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(10,38): error IDE1006: Naming rule violation:
Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(18,59): error IDE1006: Naming rule violation: Missing prefix: '_
' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(136,26): error S2094: Remove this empty class, write its code or
 make it an "interface". [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\ResilienceStrategyPipeline.cs(70,9): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\RandomUtil.cs(13,5): error IDE0021: Use block body for constructor [C:\Coding\A
pp-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\GeneratorInvoker.cs(21,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\CancellationTokenSourcePool.Pooled.cs(10,9): error IDE0021: Use block body for
constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\CancellationTokenSourcePool.Disposable.cs(9,9): error IDE0021: Use block body f
or constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceStrategy.TResult.Async.cs(13,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(43,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(51,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(46,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(54,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(63,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(19,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(22,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(29,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Fallback\FallbackHandler.Handler.cs(9,9): error IDE0021: Use block body for construct
or [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(12,5): error IDE0021: Use block body for const
ructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ConsecutiveFailuresCircuitBehavior.cs(8,5): error IDE0021:
Use block body for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ScheduledTaskExecutor.cs(14,5): error IDE0021: Use block bo
dy for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(22,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(29,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(38,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\EnrichmentContext.Pool.cs(7,59): error IDE1006: Naming rule violation
: Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(48,109): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(98,108): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(73,83): error IDE1006: Naming rule violation: Missing prefix:
'_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
  Polly.RateLimiting -> C:\Coding\App-vNext\Polly\src\Polly.RateLimiting\bin\Release\netstandard2.0\Polly.RateLimiting.dll
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\EnrichmentContext.Pool.cs(7,59): error IDE1006: Naming rule violation
: Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(48,109): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(73,83): error IDE1006: Naming rule violation: Missing prefix:
'_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(98,108): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
  Polly.RateLimiting -> C:\Coding\App-vNext\Polly\src\Polly.RateLimiting\bin\Release\net6.0\Polly.RateLimiting.dll
  Polly -> C:\Coding\App-vNext\Polly\src\Polly\bin\Release\netstandard2.0\Polly.dll
C:\Coding\App-vNext\Polly\src\Polly.TestUtils\TestArguments.cs(3,14): error S2094: Remove this empty class, write its code or
make it an "interface". [C:\Coding\App-vNext\Polly\src\Polly.TestUtils\Polly.TestUtils.csproj::TargetFramework=net481]
C:\Coding\App-vNext\Polly\src\Polly.TestUtils\TestUtilities.cs(109,9): error IDE0021: Use block body for constructor [C:\Codin
g\App-vNext\Polly\src\Polly.TestUtils\Polly.TestUtils.csproj::TargetFramework=net481]
  Polly.RateLimiting -> C:\Coding\App-vNext\Polly\src\Polly.RateLimiting\bin\Release\net472\Polly.RateLimiting.dll
  Polly.Benchmarks -> c:\Coding\App-vNext\Polly\src\Polly.Benchmarks\bin\Release\net6.0\Polly.Benchmarks.dll
  Polly -> c:\Coding\App-vNext\Polly\src\Polly\bin\Release\net472\Polly.dll
  Polly.TestUtils -> C:\Coding\App-vNext\Polly\src\Polly.TestUtils\bin\Release\net6.0\Polly.TestUtils.dll
  Polly.Extensions -> C:\Coding\App-vNext\Polly\src\Polly.Extensions\bin\Release\net6.0\Polly.Extensions.dll
  Polly.RateLimiting.Tests -> C:\Coding\App-vNext\Polly\src\Polly.RateLimiting.Tests\bin\Release\net481\Polly.RateLimiting.Tes
  ts.dll
  Polly.RateLimiting.Tests -> C:\Coding\App-vNext\Polly\src\Polly.RateLimiting.Tests\bin\Release\net6.0\Polly.RateLimiting.Tes
  ts.dll
  Polly.Specs -> C:\Coding\App-vNext\Polly\src\Polly.Specs\bin\Release\net6.0\Polly.Specs.dll
  Polly.Extensions.Tests -> C:\Coding\App-vNext\Polly\src\Polly.Extensions.Tests\bin\Release\net6.0\Polly.Extensions.Tests.dll
  Polly.Core.Tests -> C:\Coding\App-vNext\Polly\src\Polly.Core.Tests\bin\Release\net6.0\Polly.Core.Tests.dll

Build FAILED.

C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(10,38): error IDE1006: Naming rule violation:
Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(18,59): error IDE1006: Naming rule violation: Missing prefix: '_
' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(136,26): error S2094: Remove this empty class, write its code or
 make it an "interface". [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\ResilienceStrategyPipeline.cs(70,9): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\RandomUtil.cs(13,5): error IDE0021: Use block body for constructor [C:\Coding\A
pp-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\GeneratorInvoker.cs(21,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\CancellationTokenSourcePool.Disposable.cs(9,9): error IDE0021: Use block body f
or constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(46,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(54,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(63,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(72,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(12,5): error IDE0021: Use block body for const
ructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ScheduledTaskExecutor.cs(14,5): error IDE0021: Use block bo
dy for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ConsecutiveFailuresCircuitBehavior.cs(8,5): error IDE0021:
Use block body for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceStrategy.TResult.Async.cs(13,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(43,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(51,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(19,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(22,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(29,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(22,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(29,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(38,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(52,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\Fallback\FallbackHandler.Handler.cs(9,9): error IDE0021: Use block body for construct
or [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net462]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(10,38): error IDE1006: Naming rule violation:
Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(18,59): error IDE1006: Naming rule violation: Missing prefix: '_
' [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceContext.cs(136,26): error S2094: Remove this empty class, write its code or
 make it an "interface". [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\ResilienceStrategyPipeline.cs(70,9): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\RandomUtil.cs(13,5): error IDE0021: Use block body for constructor [C:\Coding\A
pp-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\PredicateInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\GeneratorInvoker.cs(21,9): error IDE0021: Use block body for constructor [C:\Co
ding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\CancellationTokenSourcePool.Pooled.cs(10,9): error IDE0021: Use block body for
constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(27,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\EventInvoker.cs(18,9): error IDE0021: Use block body for constructor [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Utils\CancellationTokenSourcePool.Disposable.cs(9,9): error IDE0021: Use block body f
or constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResilienceStrategy.TResult.Async.cs(13,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(43,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\ResiliencePropertyKey.cs(51,5): error IDE0024: Use block body for operator [C:\Coding
\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(46,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(54,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Timeout\TimeoutRejectedException.cs(63,5): error IDE0021: Use block body for construc
tor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(19,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(22,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Outcome.cs(29,5): error IDE0021: Use block body for constructor [C:\Coding\App-vNext\
Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\Fallback\FallbackHandler.Handler.cs(9,9): error IDE0021: Use block body for construct
or [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Health\HealthMetrics.cs(12,5): error IDE0021: Use block body for const
ructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ConsecutiveFailuresCircuitBehavior.cs(8,5): error IDE0021:
Use block body for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\Controller\ScheduledTaskExecutor.cs(14,5): error IDE0021: Use block bo
dy for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(22,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(29,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Core\CircuitBreaker\BrokenCircuitException.TResult.cs(38,5): error IDE0021: Use block body
 for constructor [C:\Coding\App-vNext\Polly\src\Polly.Core\Polly.Core.csproj::TargetFramework=net7.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\EnrichmentContext.Pool.cs(7,59): error IDE1006: Naming rule violation
: Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(48,109): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(98,108): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(73,83): error IDE1006: Naming rule violation: Missing prefix:
'_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=netstandard2.0]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\EnrichmentContext.Pool.cs(7,59): error IDE1006: Naming rule violation
: Missing prefix: '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(48,109): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(73,83): error IDE1006: Naming rule violation: Missing prefix:
'_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.Extensions\Telemetry\Log.cs(98,108): error IDE1006: Naming rule violation: Missing prefix:
 '_' [C:\Coding\App-vNext\Polly\src\Polly.Extensions\Polly.Extensions.csproj::TargetFramework=net472]
C:\Coding\App-vNext\Polly\src\Polly.TestUtils\TestArguments.cs(3,14): error S2094: Remove this empty class, write its code or
make it an "interface". [C:\Coding\App-vNext\Polly\src\Polly.TestUtils\Polly.TestUtils.csproj::TargetFramework=net481]
C:\Coding\App-vNext\Polly\src\Polly.TestUtils\TestUtilities.cs(109,9): error IDE0021: Use block body for constructor [C:\Codin
g\App-vNext\Polly\src\Polly.TestUtils\Polly.TestUtils.csproj::TargetFramework=net481]
    0 Warning(s)
    67 Error(s)

Time Elapsed 00:01:27.47
An error occurred when executing task '__BuildSolutions'.
Completed in 00:01:29.8604330

There should be a consistent clean build locally and in CI using out in-repo build scripts.
@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label Jun 9, 2023
@martincostello martincostello added this to the v8.0.0 milestone Jun 9, 2023
@martincostello
Copy link
Member Author

I'm working around this locally for now with:

<NoWarn>$(NoWarn);IDE1006;IDE0021;IDE0024;S2094</NoWarn>

@martintmk
Copy link
Contributor

@martincostello , strange it's working for me without issues locally.

@martintmk martintmk mentioned this issue Jun 13, 2023
Merged
4 tasks
@martincostello
Copy link
Member Author

Can no longer repro, so I think #1287 was indeed the fix.

@github-project-automation github-project-automation bot moved this to Done in Polly v8 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Polly v8
Status: Done
Milestone
v8.0.0
Development

No branches or pull requests
2 participants
@martincostello @martintmk