Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microsoft.CodeAnalysis.PublicApiAnalyzers #1090

Closed
Tracked by #1302
martincostello opened this issue Mar 31, 2023 · 1 comment
Closed
Tracked by #1302

Add Microsoft.CodeAnalysis.PublicApiAnalyzers #1090

martincostello opened this issue Mar 31, 2023 · 1 comment
Labels
CI/build up-for-grabs v8 Issues related to the new version 8 of the Polly library.
Milestone
v8.0.0

Comments

@martincostello
Copy link
Member

Once we are nearer to code complete on Polly v8, we should add the Microsoft.CodeAnalysis.PublicApiAnalyzers NuGet package into the build and configure the metadata files appropriately to "lock down" the API.

This then makes it easier going forward to identify potentially breaking changes to the API surface in future releases. We will also benefit from the built-in compatibility analysis that the package contains that might help identify any API usability issues we might inadvertently have created ahead of shipping.
@martincostello martincostello added up-for-grabs CI/build v8 Issues related to the new version 8 of the Polly library. labels Mar 31, 2023
@martincostello martincostello added this to the v8.0.0 milestone Mar 31, 2023
@martintmk martintmk moved this to Todo in Polly v8 May 2, 2023
@martintmk
Copy link
Contributor

As a part of this task we should also enable:

Polly/eng/Library.targets

Line 19 in c782d81

<PackageValidationBaselineVersion Condition="'$(PackageValidationBaselineVersion)' == ''">8.0.0</PackageValidationBaselineVersion>

@martintmk martintmk mentioned this issue Jun 15, 2023
Closed
17 tasks
@martintmk martintmk mentioned this issue Jul 13, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Polly v8 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/build up-for-grabs v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Polly v8
Status: Done
Milestone
v8.0.0
Development

No branches or pull requests
2 participants
@martincostello @martintmk