From 47284e80c063c84f2bd0a00ff2c31d1507b23aca Mon Sep 17 00:00:00 2001
From: martincostello <martin@martincostello.com>
Date: Thu, 26 Sep 2024 15:19:03 +0100
Subject: [PATCH] Fail if signing fails

Check the exit code of `sign` and fail the workflow if it does.
---
 .github/workflows/build.yml | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 67a3242598b..e19196d6432 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -193,21 +193,25 @@ jobs:
 
     - name: Sign artifacts
       shell: pwsh
-      run: >
-        ./sign code azure-key-vault
-        **/*.nupkg
-        --base-directory "${{ github.workspace }}/packages"
-        --file-list "${{ github.workspace }}/signing-config/filelist.txt"
-        --application-name "Polly"
-        --publisher-name "App vNext"
-        --description "Polly"
-        --description-url "https://github.com/${{ github.repository }}"
-        --azure-key-vault-certificate "${{ secrets.SIGN_CLI_CERT_NAME }}"
-        --azure-key-vault-client-id "${{ secrets.SIGN_CLI_APPLICATION_ID }}"
-        --azure-key-vault-client-secret "${{ secrets.SIGN_CLI_SECRET }}"
-        --azure-key-vault-tenant-id "${{ secrets.SIGN_CLI_TENANT_ID }}"
-        --azure-key-vault-url "${{ secrets.SIGN_CLI_VAULT_URI }}"
-        --verbosity "${{ runner.debug == '1' && 'Debug' || 'Warning' }}"
+      run: |
+        ./sign code azure-key-vault `
+          **/*.nupkg `
+          --base-directory "${{ github.workspace }}/packages" `
+          --file-list "${{ github.workspace }}/signing-config/filelist.txt" `
+          --application-name "Polly" `
+          --publisher-name "App vNext" `
+          --description "Polly" `
+          --description-url "https://github.com/${{ github.repository }}" `
+          --azure-key-vault-certificate "${{ secrets.SIGN_CLI_CERT_NAME }}" `
+          --azure-key-vault-client-id "${{ secrets.SIGN_CLI_APPLICATION_ID }}" `
+          --azure-key-vault-client-secret "${{ secrets.SIGN_CLI_SECRET }}" `
+          --azure-key-vault-tenant-id "${{ secrets.SIGN_CLI_TENANT_ID }}" `
+          --azure-key-vault-url "${{ secrets.SIGN_CLI_VAULT_URI }}" `
+          --verbosity "${{ runner.debug == '1' && 'Debug' || 'Warning' }}"
+        if ($LASTEXITCODE -ne 0) {
+          Write-Output "::error::Failed to sign NuGet packages"
+          exit 1
+        }
 
     - name: Upload signed packages
       uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0