refactor!: replace string types with force-validated pydantic types #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from eth_pydantic_types library (cherry picked from commit 0df69cd)
|
@antazoey 2 tests are broken but will be good to talk about tomorrow and get into how heavy to enforce the pydantic types |
fubuloubu
previously approved these changes
Oct 15, 2024
|
it's comin' along! |
fubuloubu
approved these changes
Dec 18, 2024
Comment on lines
+9
to
+10
| if TYPE_CHECKING: | ||
| from eth_pydantic_types.abi import address, bytes32, string, uint256 |
There was a problem hiding this comment.
Not performance critical, so might be worth doing it like this
Suggested change
| if TYPE_CHECKING: | |
| from eth_pydantic_types.abi import address, bytes32, string, uint256 | |
| from eth_pydantic_types import abi |
And then below do like :
...
inner: abi.uint256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
All the types used in EIP712 contracts are now using Pydantic annotated types with built-in validation
fixes: #22
Fixes: APE-1782
How I did it
This PR is being developed in coordination with an overhaul of the eth_pydantic_types library here: ApeWorX/eth-pydantic-types#11
How to verify it
Checklist