Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down scroll direction works incorrect #11

Open
Igor-Palaguta opened this issue Apr 18, 2015 · 2 comments
Open

Down scroll direction works incorrect #11

Igor-Palaguta opened this issue Apr 18, 2015 · 2 comments

Comments

@Igor-Palaguta
Copy link
Contributor

https://github.com/Antondomashnev/ADTickerLabel/blob/master/ADTickerLabel.m#L125

Should be

if (![selectedCharacter isEqualToString:@"."]){
            selectedCharacterIndex--;
        }
@Igor-Palaguta
Copy link
Contributor Author

Also pay attention that in your sample when we change it from 18741984 to 897. When direction is down we have "89."
in updateTickerCharacterViewsFrames you change frame, but you don't update selectedCharacterIndex
That is why it still think that third character is 7, but really it points to first character

@Igor-Palaguta
Copy link
Contributor Author

These issues are also fixed here: https://github.com/Igor-Palaguta/ADTickerLabel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant