Multiple HTTP assertions against one handler.

[brackendawson]

If someone uses more than one HTTP assertion with the same handler with the same args, eg:

assert.HTTPStatusCode(t, handler, "GET", "/path", nil, 200)
assert.HTTPBodyContains(t, handler, "GET", "/path", nil, "hello")

Then this is not testing for state. A stateful handler could satisfy the tests independently but not in a single call.

A better implementation uses httptest from the standard library:

r := httptest.NewRequest("GET", "/path", nil)
w := httptest.NewRecorder()
handler(w, r)
assert.Equal(t, w.Code, 200)
assert.Contains(t, w.Body.String(), "hello")

This was discussed in stretchr/testify#925.

The HTTP assertions are:

• HTTPBody
• HTTPBodyContains
• HTTPBodyNotContains
• HTTPError
• HTTPRedirect
• HTTPStatusCode
• HTTPSuccess