Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite used as assert.WhatEver(suite.T(), ... #123

Closed
ccoVeille opened this issue Jun 13, 2024 · 4 comments
Closed

suite used as assert.WhatEver(suite.T(), ... #123

ccoVeille opened this issue Jun 13, 2024 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@ccoVeille
Copy link
Contributor

Example

https://github.com/wanliu/go-oauth2-server/blob/f928fa1580dfcb03bfa77c2786980800f4af2c68/oauth/introspect_test.go#L152

assert.NoError(suite.T(), err, "Inserting test data failed")

The pattern is very common
https://github.com/search?q=%22assert.NoError%28suite.T%28%29%22&type=code

@ccoVeille
Copy link
Contributor Author

ccoVeille commented Jun 13, 2024

Do you agree it's something that should be suggested to fix ?

suite.NoError(err, "Inserting test data failed")

maybe something to add to suite-subtest-run

@Antonboom
Copy link
Owner

@ccoVeille
Copy link
Contributor Author

I'm so tired 😩 … I checked it in the unit tests of suite-subtest, which of course don't catch it. I should have launched testifylint directly 🤦

@ccoVeille
Copy link
Contributor Author

So duplicate of #35, implemented in #104

@Antonboom Antonboom added duplicate This issue or pull request already exists wontfix This will not be worked on and removed wontfix This will not be worked on labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants