From b379446c8f3202c7db313a86c2e6842500694d79 Mon Sep 17 00:00:00 2001 From: ccoVeille <3875889+ccoVeille@users.noreply.github.com> Date: Sun, 7 Apr 2024 10:13:07 +0200 Subject: [PATCH] Add links in CONTRIBUTING.md This would help people to find explanation or reuse an existing issue when implementing it. --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 482fec27..cd0d7864 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -179,6 +179,7 @@ Describe a new checker in [checkers section](./README.md#checkers). **Autofix**: false.
**Enabled by default**: true.
**Reason**: The `Error()` method on the `error` interface exists for humans, not code. +**Related issues**: #47 --- @@ -312,6 +313,7 @@ And similar idea for `assert.InEpsilonSlice` / `assert.InDeltaSlice`. **Autofix**: true.
**Enabled by default**: maybe?
**Reason**: More appropriate `testify` API with clearer failure message. +**Related issues**: #76 --- @@ -319,6 +321,7 @@ And similar idea for `assert.InEpsilonSlice` / `assert.InDeltaSlice`. **Autofix**: true.
**Enabled by default**: maybe? +**Related issues**: #33 Those who are new to `testify` may be discouraged by the duplicative API: @@ -471,6 +474,7 @@ assert.ErrorContains(t, err, "user") ❌ **Autofix**: true.
**Enabled by default**: false.
**Reason**: Just for your reflection and suggestion. +**Related issues**: #75 I'm not sure if anyone uses `assert.Zero` – it looks strange and conflicts with `assert.Empty`: