Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Aim assist ignore FOV parameter (on player) #284

Closed
Starmania opened this issue Aug 24, 2023 · 2 comments
Closed

[Bug] Aim assist ignore FOV parameter (on player) #284

Starmania opened this issue Aug 24, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Starmania
Copy link
Contributor

Starmania commented Aug 24, 2023

Describe the bug

Aim assist does not respect FOV parameter

Crashlog

N\A

Steps to reproduce

  1. Configure Aim Assist with a FOV
  2. Activate it
  3. Any player in the distance will be catched

Operating System

Windows

Addon Version

8645f2d

Meteor Version

1917

Minecraft Version

1.20.1

Other mods

  [✔️] clientcommands-2.8.3.jar
  [✔️] fabric-api-0.87.0+1.20.1.jar
  [✔️] litematica-fabric-1.20.1-0.15.3.jar
  [✔️] lithium-fabric-mc1.20.1-0.11.2.jar
  [✔️] malilib-fabric-1.20.1-0.16.1.jar
  [✔️] meteor-client-0.5.4-1917.jar
  [✔️] meteor-rejects-addon-0.3.jar
  [✔️] modmenu-7.2.1.jar
  [✔️] sodium-fabric-mc1.20.1-0.5.2.jar
  [✔️] viafabricplus-2.8.2.jar
  [✔️] Xaeros_Minimap_23.6.3_Fabric_1.20.jar
  [✔️] XaerosWorldMap_1.33.1_Fabric_1.20.jar
@Starmania Starmania added the bug Something isn't working label Aug 24, 2023
@Starmania
Copy link
Contributor Author

Oh, and when reading the code, the problem is here (I think)

if (entity instanceof PlayerEntity) return Friends.get().shouldAttack((PlayerEntity) entity);
return RejectsUtils.inFov(entity, fov.get());

@Starmania
Copy link
Contributor Author

Because I was attacking a player, and it was not part of my friend, first condition is always true and FOV never checked

@Starmania Starmania changed the title [Bug] [Bug] Aim assist ignore FOV parameter (on player) Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants