fix: fixed error in deleteAll method

AnthonyLzq · Dec 19, 2021 · 0e3455d · 0e3455d
1 parent acaf8a1
commit 0e3455d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/example/src/controllers/user.ts b/example/src/controllers/user.ts
@@ -63,7 +63,10 @@ class User {
     try {
       const usersDeleted = await UserModel.deleteMany({})
 
-      if (usersDeleted.acknowledged) return MFU.ALL_USERS_DELETED
+      if (usersDeleted.deletedCount >= 1) return MFU.ALL_USERS_DELETED
+
+      if (usersDeleted.deletedCount === 0)
+        throw new httpErrors.BadRequest(EFU.NOTHING_TO_DELETE)
 
       throw new httpErrors.InternalServerError(GE.INTERNAL_SERVER_ERROR)
     } catch (e) {

diff --git a/example/src/controllers/utils/messages/user.ts b/example/src/controllers/utils/messages/user.ts
@@ -1,5 +1,6 @@
 enum ErrorForUser {
-  NOT_FOUND = 'The requested user does not exists'
+  NOT_FOUND = 'The requested user does not exists',
+  NOTHING_TO_DELETE = 'There is no user to be deleted'
 }
 
 enum MessageForUser {

diff --git a/lib/src/functions/express.js b/lib/src/functions/express.js
@@ -162,7 +162,10 @@ class User {
     try {
       const usersDeleted = await UserModel.deleteMany({})
 
-      if (usersDeleted.acknowledged) return MFU.ALL_USERS_DELETED
+      if (usersDeleted.deletedCount >= 1) return MFU.ALL_USERS_DELETED
+
+      if (usersDeleted.deletedCount === 0)
+        throw new httpErrors.BadRequest(EFU.NOTHING_TO_DELETE)
 
       throw new httpErrors.InternalServerError(GE.INTERNAL_SERVER_ERROR)
     } catch (e) {
@@ -256,7 +259,8 @@ export { EFU, MFU, GenericErrors as GE }
       },
       user: {
         content: `enum ErrorForUser {
-  NOT_FOUND = 'The requested user does not exists'
+  NOT_FOUND = 'The requested user does not exists',
+  NOTHING_TO_DELETE = 'There is no user to be deleted'
 }
 
 enum MessageForUser {