From 001d4d27fc2cd24be9dc3d15ad9e2338051d86e9 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Mon, 7 Oct 2024 22:02:54 +0200 Subject: [PATCH] docs: use npm ci in CONTRIBUTING.md (#5040) --- CONTRIBUTING.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 516e67d5242..374f0470d08 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -29,9 +29,9 @@ detailed instructions, see [development](#development) below. ```sh git clone https://github.com/open-telemetry/opentelemetry-js.git cd opentelemetry-js -npm install +npm ci npm run compile -npm test +npm run test ``` ## Pull Request Merge Guidelines @@ -164,7 +164,7 @@ Most of the commands needed for development are accessed as [npm scripts](https: This will install all dependencies for the root project and all modules managed by `npm workspaces`. ```sh -npm install +npm ci ``` ### Compile modules @@ -293,10 +293,10 @@ export const _globalThis = typeof globalThis === 'object' ? globalThis : global; /// packages/opentelemetry-core/src/platform/browser/globalThis.ts export const _globalThis: typeof globalThis = typeof globalThis === 'object' ? globalThis : - typeof self === 'object' ? self : - typeof window === 'object' ? window : - typeof global === 'object' ? global : - {} as typeof globalThis; + typeof self === 'object' ? self : + typeof window === 'object' ? window : + typeof global === 'object' ? global : + {} as typeof globalThis; ``` Even though the implementation may differ, the exported names must be aligned.