Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async file I/O #2

Open
rishabh-gupta2 opened this issue Jan 5, 2022 · 0 comments
Open

Use async file I/O #2

rishabh-gupta2 opened this issue Jan 5, 2022 · 0 comments

Comments

@rishabh-gupta2
Copy link

Summary

The current implementation uses the await fs.writeFileSync . This leads to reduced performance for the script with contention on file I/O.

Suggestion

Wanted to understand if there is any particular reason you chose to go with sync file I/O, instead of async implementation writeFile. If not, I can raise a PR for the same, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant