From 2c4626badde4aa8c703a8b0e2b00dd773c72840c Mon Sep 17 00:00:00 2001 From: angusj Date: Thu, 9 Nov 2023 14:35:33 +1000 Subject: [PATCH] Correct of typo in code documentation :) --- CPP/Tests/TestOffsetOrientation.cpp | 8 +++++--- CPP/Tests/googletest | 1 - 2 files changed, 5 insertions(+), 4 deletions(-) delete mode 160000 CPP/Tests/googletest diff --git a/CPP/Tests/TestOffsetOrientation.cpp b/CPP/Tests/TestOffsetOrientation.cpp index 8ebfc533..b668a097 100644 --- a/CPP/Tests/TestOffsetOrientation.cpp +++ b/CPP/Tests/TestOffsetOrientation.cpp @@ -24,9 +24,11 @@ TEST(Clipper2Tests, TestOffsettingOrientation2) { co.Execute(5, solution); ASSERT_EQ(solution.size(), 2); - // when offsetting, output orientation should match input EXCEPT when ReverseSolution == true - // HOWEVER, input path order MANY NOT MATCH output path order, for example when inner paths (holes) - // are defined before their container outer paths (as above). + // When offsetting, output orientation should match input EXCEPT when ReverseSolution == true + // However, input path ORDER may not match output path order. For example, order will change + // whenever inner paths (holes) are defined before their container outer paths (as above). + // And when offsetting multiple outer paths, their order will likely change too. Due to the + // sweep-line algorithm used, paths with larger Y coordinates will likely be listed first. EXPECT_TRUE(Clipper2Lib::IsPositive(subject[1]) != Clipper2Lib::IsPositive(solution[0])); } diff --git a/CPP/Tests/googletest b/CPP/Tests/googletest deleted file mode 160000 index 5e6a5336..00000000 --- a/CPP/Tests/googletest +++ /dev/null @@ -1 +0,0 @@ -Subproject commit 5e6a533680fc8292c31f31664d80c48440d4a526