Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weedwood crafting table display doesn't clear items correctly #1407

Open
JoshieGemFinder opened this issue Aug 26, 2024 · 0 comments
Open

Weedwood crafting table display doesn't clear items correctly #1407

JoshieGemFinder opened this issue Aug 26, 2024 · 0 comments

Comments

@JoshieGemFinder
Copy link
Collaborator

Versions

Betweenlands version:

The Betweenlands v3.9.6

Forge version:

forge 1.12.2 - 14.23.5.2860

Singleplayer or Multiplayer:

Singleplayer (harder to notice) & Multiplayer (all server architectures)

Installed mods:

The Betweenlands v3.9.6
JEI

Description of the problem

How to reproduce:

  1. Place weedwood crafting table
  2. Have another account craft something in it (do not have the inventory open when it is crafted)
  3. Look at the items rendered on top

Expected result:

New items in table would update when the items are taken out of the table

Actual result:

Items that are reduced to empty slots will not be cleared from the table, items that are remainders from the recipe (such as the buckets in a cake recipe) will update correctly.

Cause:

The utils do not write empty slots to NBT; when the NBT is read on the client, items that should be now empty slots are not replaced with an empty slot.
Recommended fix: clear the item list when reading items from an update packet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant