[Fix] Move to curl and shows errors on fetch of script #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2021 09:16
I'm proposing removing the use of wget for two reasons: - Using wget was set to `--quiet` which hides an error message around using the `--no-check-certificate` but users can't see that. cURL works and doesn't need to have any extra flags passed to the command. - wget is not installed as standard on macs where cURL is, alternatively I'm happy for this to be declined and add an error on it being missing as a pre-install check? This is possibly causing issues for others installing on the latest versions of macOS too.
Using `install.sh` is ambiuguous for consumption and could be used by other installation scripts. I've renamed to allow the user to identify the installation script easier in order to delete it if they feel they need to.
On FreeBSD, neither is installed, there is a fetch utility. It seems a reasonable requirement to expect people to have wget on every platform. In another hand, most automatic web installation offers curl shell script | shell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing removing the use of wget for two reasons:
Using wget was set to
--quietwhich hides an error message aroundusing the
--no-check-certificatebut users can't see that. cURL worksand doesn't need to have any extra flags passed to the command.
wget is not installed as standard on macs where cURL is, alternatively
I'm happy for this to be declined and add an error on it being missing as
a pre-install check? This is possibly causing issues for others installing
on the latest versions of macOS too.