Custom criteria Angular code being deleted

[rickbutterfield]

I've created a custom criteria in C# and that works absolute fine, but if I create a custom folder under App_Plugins/PersonalisationGroups it gets removed on every build. Currently I think custom ones have to be under this folder to be picked up?

UmbracoPersonalisationGroupsCore/PersonalisationGroups/App_Plugins/PersonalisationGroups/personalisaton-group-definition.controller.js

Line 83 in d8a250f

var templateUrl = "/App_Plugins/PersonalisationGroups/Criteria/" + convertAliasToFolderName(definitionDetail.alias) + "/definition.editor.html";

[AndyButland]

Yes, that makes sense - I think this could be problematic. Will have a look and see what we could do about this, I guess either allowing a different path, or making sure the build process only removes files actually installed by the package.

[AndyButland]

Think I've found a resolution to this, though it does involve a small breaking change in the addition of a new property on IPersonalisationGroupCriteria, where you can provide a folder for the client-side assets.

Would you mind having a look over the linked PR to see if you think that'll work for you? And if so, I'll merge it in and push out an update.

[rickbutterfield]

@AndyButland Just pulled it into my solution and it's worked a treat! 🎉

[AndyButland]

Good to hear, thanks. Have released as 3.1.0.