Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: dist: trusty (vs precise) slows down vimrunner #48

Open
blueyed opened this issue Jul 29, 2017 · 3 comments
Open

Travis: dist: trusty (vs precise) slows down vimrunner #48

blueyed opened this issue Jul 29, 2017 · 3 comments

Comments

@blueyed
Copy link

blueyed commented Jul 29, 2017

We're using vimrunnter for https://github.com/Vimjas/vim-python-pep8-indent, and I've noticed that switching to the "Trusty" images on Travis (from Precise) slows down the tests from 2 minutes to 10, and there has been a timeout even once.

Trusty has vim 7.4.0052 (VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov 24 2016 16:42:52); Included patches: 1-52), whereas Precise has 7.3.429 (VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Nov 24 2016 00:51:24); Included patches: 1-429).

Any idea what might be causing this?

The tests: https://github.com/Vimjas/vim-python-pep8-indent/blob/master/spec/indent/indent_spec.rb
Probably there's something to be improved there anyway?!

Example build: https://travis-ci.org/Vimjas/vim-python-pep8-indent/builds/258866607

@AndrewRadev
Copy link
Owner

AndrewRadev commented Jul 29, 2017

Hmm, I have to admit, I have no idea what could be causing this. I switched to trusty for most of my plugins, and I've seen no slowdown -- for splitjoin, tests consistently pass in 1-2 mins.

There might be something specific to the plugin, related to the Vim version. I have Vim installed from source, so I can change the git tags and recompile. I'll try the plugin out in both Vim versions and see if I can reproduce the slowdown locally.

Unfortunately, these days I'll be quite busy, so I can't guarantee when I'll get around to it... If you'd like to experiment yourself, you could try compiling Vim. It's on git nowadays, so checking out the right version shouldn't be difficult. You could also change Vimrunner.start to Vimrunner.start_gvim in order to visually see where the slowdowns are. Maybe something is hanging? Not sure.

@blueyed
Copy link
Author

blueyed commented Jul 29, 2017

Thank you.
JFI: it is also slow when using Docker on Travis (based on Debian Jessie): https://travis-ci.org/Vimjas/vim-python-pep8-indent/builds/258878083

Will try to use/build Vim from master.

@AndrewRadev
Copy link
Owner

I compiled Vim at 7.4.0059, but I can't really see any slowdown. I'm wondering if it isn't the terminal vim hangup that we discussed in a different thread. Could you try switching the plugin to use start_gvim (to start a graphical instance), and see if the Travis-CI slowdown still happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants