-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash and compare archetype identifiers by address #164
Conversation
The performance regression is in the call from the entry API into |
With the last commit, the problem is now fixed. This PR is ready to go. |
Codecov Report
@@ Coverage Diff @@
## dev #164 +/- ##
==========================================
+ Coverage 94.77% 94.80% +0.02%
==========================================
Files 73 73
Lines 10785 10857 +72
==========================================
+ Hits 10222 10293 +71
- Misses 563 564 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR sees improvements in the old Overall, this is a good change that improves performance and removes unnecessary computations. |
Fixes #160.
There is currently a regression with adding and removing components via the entry API. Seems to have increased tenfold. Will have to investigate before merging.