Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save browsing history when app is closed #231

Closed
tuomas2 opened this issue Jan 22, 2019 · 4 comments
Closed

Save browsing history when app is closed #231

tuomas2 opened this issue Jan 22, 2019 · 4 comments

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 22, 2019

From user:

Please make the browsing history persist after the app is closed, and also when navigating through the history:
► It is often the case that one wishes to revisit the last verses viewed, some time after running the app. Currently however, the history is empty when starting the app again - and the history of the previous reading session is lost.
► Also, when one currently backtracks in the history by several steps, the later verses in the history are irretrievably lost, as if permanently popped off of a stack. Instead, it would be more helpful if one could browse backwards AND forwards through the history, as if following the same train of thought. Example: we read the following verses: Mat 1:1, Mar 1:1, Luk 1:1, Joh 1:1 ... And then wish to retrace our steps from the Matthew verse; but if we go back 3 times from John, the Mark & Luke verses are lost from history and there is no way to proceed "forward" again from the Matthew verse.

Related pull request #54

@timbze
Copy link
Contributor

timbze commented Apr 26, 2019

Just an idea, but it might be an option to have a separate history per tab (#355) and overall.
For example, have a history like Chrome's browsing history, where every Scripture change is recorded, regardless of window or tab. And have a separate history per window or per tab which controls where the back button will take the user. I think it would not work to navigate with back button to the last overall history, but would have to be specific to either the tab or window.
There already was an attempt at persistent history here #54 but seems no conclusion was reached at that time.

Could have the screen something like this (a prettier design hopefully), with a button to see all history.
ab_history_screen

@tuomas2
Copy link
Contributor Author

tuomas2 commented May 23, 2019

Will be implemented in build 308

@bvahedy
Copy link

bvahedy commented May 24, 2019

Verified fix in 308 beta.

@bvahedy bvahedy removed their assignment May 24, 2019
@tuomas2 tuomas2 added this to the v3.2 milestone May 24, 2019
@gdiamant
Copy link

Thank you very much for working on this, this will be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants