-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base polygon geometry rectangle IDL handling on Rectangle.fromCartesianArray #7533
Conversation
Thanks for the pull request @likangning93!
Reviewers, don't forget to make sure that:
|
Fixes a bug introduced in this release, so no CHANGES.md update. |
@likangning93 should there be a unit test for this? |
There's an IDL test case already, the corner case @shehzan10 found was a false-positive for IDL cross. I can add the cases from |
Thanks @likangning93 this fixes the issue. We can get it in if you fix up those tests soon. |
Looks like the previous case was also only for rhumb, whoops. |
ad2f587
to
572a943
Compare
Okay looks like |
Looks great, thanks @likangning93! |
@shehzan10 noticed that geodetic polygons had weird rectangles sometimes when crossing the PM.
Here in master
This PR updates the IDL handling for geodetic polygons to more closely match what
Rectangle.fromCartesianArray
does, which seems to be correct.