-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More careful splitting of glTF materials #6421
Conversation
@emackey, thanks for the pull request! Maintainers, we have a signed CLA from @emackey, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
@emackey looks good, just update CHANGES.md. |
Actually, going to add one more tweak here, hold on... |
Updated. Now fixes #6061. This is ready. |
Nice - Polly and Alien work great. |
This addresses a bug found in #6412 where Polly, the robot dog, lost all her lighting, even emissive lights.
Some materials were used with and without tangents, or with and without morph targets, and needed to be split apart. Also, the
hasTangents
andhasMorphTargets
booleans needed to be isolated to their respective materials (after splitting).