Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a demo showing how a single entity can be split across CZML files. #6320

Merged
merged 6 commits into from
Mar 12, 2018

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Mar 10, 2018

This demo adds a copy of the existing Vehicle.czml file, split across 3 new files. The demo loads only the first part, and watches the clock to see when other parts are needed.

Of course, for such a small vehicle path, this extra work isn't required. It's just here to show how the parts would fit together in a larger application that needed to split up CZML files.

TODO:

  • Need to add thumbnail
  • CHANGES.md

@shunter Any chance you can review?

/cc @pjcozzi @mramato

@cesium-concierge
Copy link

Signed CLA is on file.

@emackey, thanks for the pull request! Maintainers, we have a signed CLA from @emackey, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@emackey emackey requested a review from shunter March 10, 2018 18:13
@emackey
Copy link
Contributor Author

emackey commented Mar 10, 2018

Demoing off a branch always seems slow, but, here's the link: Multi-part CZML Demo

EDIT: Use @mramato's link below instead.

@mramato
Copy link
Contributor

mramato commented Mar 10, 2018

@emackey, use the built Sandcastle instead

http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/multipart-czml-demo/Build/Apps/Sandcastle/index.html?src=Multi-part%20CZML.html&label=Showcases

@emackey
Copy link
Contributor Author

emackey commented Mar 10, 2018

Thanks, that seems faster.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 10, 2018

Awesome @emackey, thanks for adding this so quickly. To make this a more complete example for the folks requesting it, could you please swap out the billboard with the milktruck or another model. Just do whatever is reasonable for orientation even if it is export something quick from STK.

Would also love to see the latest way to use a custom property and display it as an overlay.

@emackey
Copy link
Contributor Author

emackey commented Mar 10, 2018

OK, branch is still building but demo link will be the same when it's done.

The 3D model is used now with auto-orientation from Cesium.

A multi-part custom property "fuel remaining" has been added, split across all 3 parts of the CZML. Cesium automatically interpolates the value smoothly, even between values that came from different CZML files.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 10, 2018

@emackey this is perfect, thanks. 👏

@mramato @shunter any suggestions before we merge?

Copy link
Contributor

@shunter shunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 12, 2018

Awesome, thanks again!

@pjcozzi pjcozzi merged commit c0cf087 into master Mar 12, 2018
@pjcozzi pjcozzi deleted the multipart-czml-demo branch March 12, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants