Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelAnimationCache Memory use bug with DataURIs #6928

Closed
mksquires opened this issue Aug 16, 2018 · 3 comments
Closed

ModelAnimationCache Memory use bug with DataURIs #6928

mksquires opened this issue Aug 16, 2018 · 3 comments

Comments

@mksquires
Copy link

mksquires commented Aug 16, 2018

The ModelAnimationCache currently uses model.cacheKey and uriKey in tandem as part of the key for models in the cache. When embedding a reasonably sized model in czml this results in the model's data being used as the cache key. In doing this memory can become rapidly exhausted. Please see the czml file in the following gist: https://gist.github.com/mksquires/0662e8cd7475c98fe63175ffd047a8ee for a demonstration of this issue.

@hpinkos
Copy link
Contributor

hpinkos commented Aug 16, 2018

Thanks for reporting this @mksquires! Do you have time to open a pull request to address this bug? If not, we'll try to look into it soon

@mksquires
Copy link
Author

mksquires commented Aug 16, 2018 via email

@hpinkos
Copy link
Contributor

hpinkos commented Aug 16, 2018

Perfect, thanks! Let us know if you have any questions =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants