Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header #14

Closed
3 tasks
Tracked by #15
, #21
...
thescientist13 opened this issue Sep 3, 2022 · 2 comments · Fixed by #41
Closed
3 tasks
Tracked by #15
, #21
...

Header #14

thescientist13 opened this issue Sep 3, 2022 · 2 comments · Fixed by #41
Assignees
@aholtzman
Labels
feature New feature or request good first issue Good for newcomers sponsorship:eligible
Milestone
Website v1.0

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Sep 3, 2022 •
edited
Loading

Overview

Create the Header component w/ navigation.

Screen Shot 2022-10-08 at 2 17 23 PM

Some notes:

  1. Would use stacked header logo (will work on getting an actual image from the designer, can just do a screen grab for now)
  2. No navigation needed in header for now, page will just use vertical scrolling and there is only this page.

Would be nice to achieve the "tearing" design, not sure if it should be in the header or as part of the top of the home page? We will have actual links soon to a couple other pages, then the navigation would be inside that tearing effect, so leaning towards yes? 🤔

Requirements

  1. Component
  2. Storybook
  3. Spec
@thescientist13 thescientist13 added this to the Website v1.0 milestone Sep 3, 2022
@thescientist13 thescientist13 mentioned this issue Sep 3, 2022
Closed
5 tasks
@VedanthB
Copy link

VedanthB commented Sep 4, 2022

I'd like to give this a try.

@thescientist13 thescientist13 added invalid This doesn't seem right and removed good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right sponsorship:eligible labels Sep 4, 2022
@thescientist13 thescientist13 self-assigned this Sep 4, 2022
@thescientist13
Copy link
Contributor Author

Hey @VedanthB , thanks for reaching out! This issue isn't quite ready yet, and apologies on my end for mis-labeling. But please feel free to see if any of the other help wanted issues are of interest to you and let me know if you have any questions.

@thescientist13 thescientist13 added good first issue Good for newcomers and removed invalid This doesn't seem right labels Oct 2, 2022
@thescientist13 thescientist13 changed the title Header / Navigation Header Oct 8, 2022
@thescientist13 thescientist13 changed the title Header Header / Navigation Oct 8, 2022
@thescientist13 thescientist13 removed their assignment Oct 8, 2022
@thescientist13 thescientist13 changed the title Header / Navigation Header Oct 8, 2022
@thescientist13 thescientist13 mentioned this issue Oct 8, 2022
Closed
11 tasks
@aholtzman aholtzman mentioned this issue Oct 10, 2022
Merged
3 tasks
@thescientist13 thescientist13 moved this from 🔖 Ready to 👀 In review in TT.tv Website Design (v1) Oct 11, 2022
@thescientist13 thescientist13 moved this from 👀 In review to ✅ Done in TT.tv Website Design (v1) Oct 16, 2022
@thescientist13 thescientist13 linked a pull request Oct 16, 2022 that will close this issue
add basic header component based on spec #41
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aholtzman aholtzman

Labels
feature New feature or request good first issue Good for newcomers sponsorship:eligible
Projects
TT.tv Website Design (v1)
Status: ✅ Done
Milestone
Website v1.0
Development

Successfully merging a pull request may close this issue.

add basic header component based on spec AnalogStudiosRI/www.tuesdaystunes.tv
3 participants
@thescientist13 @aholtzman @VedanthB