-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restoring social share #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy Preview for practical-fermat-fa2c48 ready! 🔨 Explore the source changes: 92c5562 🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-fermat-fa2c48/deploys/61cf87f648c99f0008636e52 😎 Browse the preview: https://deploy-preview-54--practical-fermat-fa2c48.netlify.app/ |
thescientist13
added
needs upstream
help wanted
Extra attention is needed
question
Further information is requested
labels
Dec 11, 2021
This was referenced Dec 11, 2021
thescientist13
changed the title
WIP of integrating and restoring social share
[WIP] integrating and restoring social share
Dec 21, 2021
thescientist13
removed
needs upstream
help wanted
Extra attention is needed
question
Further information is requested
labels
Dec 23, 2021
thescientist13
changed the title
[WIP] integrating and restoring social share
restoring social share
Dec 23, 2021
thescientist13
force-pushed
the
feature/issue-39-restore-social-share
branch
from
December 24, 2021 00:14
d1687fe
to
bcaafe9
Compare
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #39
Summary of Changes
So there seem to be some issues(1, 2 with Stencil that made progress on this a bit challenging, but with a little tweaking to a fork, I got things working by:
module
field to dist/websocialshare/websocialshare.esm.js instead of dist/esm/index.js, which was just resolving to to an empty fileTODOs
build
command