Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/update home page to lit2 #17

Merged
merged 20 commits into from
Nov 12, 2021
Merged

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Sep 18, 2021

Related Issue

#11 / #12

Summary of Changes

Throwing together a quick spike just to measure the effort of getting the home page upgraded to Lit@2 + Bootstrap + API calls, still quite a lot to do though.

Screen Shot 2021-09-30 at 4 21 07 PM
Screen Shot 2021-09-30 at 4 12 43 PM

TODOs

  1. Bootstrap
  2. Font Awesome
  3. Header - deferred to header styles do not match production #21
  4. Footer
  5. Banner
  6. Events Calendar
  7. Posts Lists
  8. Bundle CSS / Font Awesome / Bootstrap for develop and production
  9. Deploy preview API requests not working? - works here though? this is a test ContributaryCommunity/www.contributary.community#100
    Screen Shot 2021-10-13 at 1 05 36 PM
  10. Misc Style Issues - deferred to home page styles are slightly off #22
    • refactor SCSS @include mixin usages, likely the culprit for
      • home page banner width
      • posts lists / events calendar height not matching
      • header / navigation styles
      • solid fill for center page content
    • refactor SCSS functions darken, transparentize
    • very large FOUC (in development anyway)
    • restore lint:css to top level lint task and fix stylelint warnings
  11. Restore tests
  12. October 2021 is missing the 31st 📆. (opportunity for Temporal API?) - differed to some months (October 2021) are missing the 31st day #23
    Screen Shot 2021-10-21 at 2 11 37 PM
  13. Restore Storybook (fix issue resolving nested font-awesome.svg files) - deferred tohttps://github.com/restore storybook #24
  14. Restore Google Analytics - deferred to restore Google Analytics for SPA #25
  15. Track discussion for Case study / major CSS refactor (Greenwood + design systems, start a discussion) - [WIP] Phase 1 Case Study #20
  16. perf before and after -deferred to Lighthouse and general DX performance benchmarks and analysis  #27
  17. Future CSS enhancements (SASS plugin) - deferred to CSS bundling / refactoring (SASS plugin?) #28
  18. Publish a Greenwood Font Awesome Plugin - deferred to publish font awesome plugin to NPM #26

@thescientist13 thescientist13 self-assigned this Sep 18, 2021
@netlify
Copy link

netlify bot commented Sep 18, 2021

✔️ Deploy Preview for practical-fermat-fa2c48 ready!

🔨 Explore the source changes: c9bc117

🔍 Inspect the deploy log: https://app.netlify.com/sites/practical-fermat-fa2c48/deploys/618d42564d56250007ca47f2

😎 Browse the preview: https://deploy-preview-17--practical-fermat-fa2c48.netlify.app/

@thescientist13 thescientist13 added this to the Jamstack Migration milestone Oct 28, 2021
@thescientist13 thescientist13 marked this pull request as ready for review November 11, 2021 16:18
@thescientist13 thescientist13 merged commit 645fe70 into main Nov 12, 2021
@thescientist13 thescientist13 deleted the spike/update-home-page-to-lit2 branch November 12, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Pages Migrate Components and Services
1 participant