Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore social share implementation for details pages (artist, album, event) #39

Closed
1 of 7 tasks
thescientist13 opened this issue Nov 17, 2021 · 1 comment · Fixed by #54
Closed
1 of 7 tasks

restore social share implementation for details pages (artist, album, event) #39

thescientist13 opened this issue Nov 17, 2021 · 1 comment · Fixed by #54
Assignees
@thescientist13
Labels
feature New feature or request
Milestone
Jamstack Migration

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Nov 17, 2021 •
edited
Loading

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

The previous implementation relied on an Angular specific package(ng2-social-share).

Details

Will need to find an alternative for

  1. artist details
  2. album details
  3. event details
@thescientist13 thescientist13 added the feature New feature or request label Nov 17, 2021
@thescientist13 thescientist13 added this to the Jamstack Migration milestone Nov 17, 2021
@thescientist13 thescientist13 self-assigned this Nov 17, 2021
@thescientist13 thescientist13 mentioned this issue Nov 17, 2021
Merged
4 tasks
@thescientist13 thescientist13 changed the title restore social share implementation for artists and album details pages restore social share implementation for details pages (artist, album, event) Nov 17, 2021
@thescientist13 thescientist13 mentioned this issue Nov 27, 2021
Closed
19 tasks
@thescientist13
Copy link
Contributor Author

thescientist13 commented Dec 4, 2021 •
edited
Loading

Was looking around and saw web-social-share which is WC variant, but as part of testing noticed there might be some issues with its published ESM package? Looking forward to giving it a try since it seems like a nice replacement, and even exposes some theming via CSS variables. 💯

Update 1: peterpeterparker/web-social-share#48 (comment)

@thescientist13 thescientist13 mentioned this issue Dec 5, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
feature New feature or request
Projects
None yet
Milestone
Jamstack Migration
Development

Successfully merging a pull request may close this issue.

restoring social share AnalogStudiosRI/www.analogstudios.net
1 participant
@thescientist13