Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hetzner list only first 100 entries of domain #1389

Closed
mander1000 opened this issue Sep 5, 2022 · 2 comments
Closed

Hetzner list only first 100 entries of domain #1389

mander1000 opened this issue Sep 5, 2022 · 2 comments

Comments

@mander1000
Copy link
Contributor

First, thanks for the awesome library we have been using for quite a long.

However, we don't see all entries if listing all entries of the domain. We reached over 100 entries within our domain managed by hetzner, or hetzner perhaps changed their interface.

Within the hetzner implementation, a filter exists to list max 100 entries, which paginates all entries. (https://github.com/AnalogJ/lexicon/blob/master/lexicon/providers/hetzner.py#L76)

I would expect to list all entries, not only the first 100.

Removing the filter "per_page" will list all entries (as also documented by the hetzner docu). So I will upload a fix for that as well.

Cheers
mander

@mander1000
Copy link
Contributor Author

Thanks for the merge. Should be fixed now.

@adferrand
Copy link
Collaborator

You are welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants