Restore Gauge Correlation Comment / Info Text Field

[ngottlieb]

Correlations used to have a comment field that allowed users to write things like, "This gauge is 10 miles downstream, so expect actual flows in the reach to be delayed X hours" (per Tony Allred comments on Streamteam forum).

• Restore field on backend (@tallowen)
• Add editing interface for front-end (@ngottlieb)
• Migrate old data to new system (@tallowen)

[tallowen]

Added to the db / api - you should be able to add a comment field now.

[ngottlieb]

@AWKevin @riversandcreeks this is up on beta now, including the restoration of the old comments. Please let me know your thoughts on the interface for both reading and updating them.

NOTE: gauge-related information has no "beta" environment. What you see here within the flow tab is production data. Any edits you make will be reflected on production. When I'm testing things here, I will typically make changes to relatively obscure rivers and reverse it when I'm done.

[AWKevin]

I don't see any correlation comments on flow tabs on Beta. Maybe I just can't find a river with a gauge comment - but I think I am visiting pages that should have them.

I added a comment to this river but did not see it reflected on the page after I saved it and clicked refresh a few times. https://beta.americanwhitewater.org/content/River/view/river-detail/11100/flow

UI worked well in terms of location and process. I think "Correlation comment" is kind of jargon from our team that is not intuitive. I suggest we say something more explicit like: "Comment on the correlation between this gauge and this reach (Optional)." We could even go longer like : "Comment on the correlation between this gauge and this reach (Optional). This comment will appear below the graph on the flow tab. Comments might include location of the gauge relative to the reach, time delays, tributary inputs, or other factors that affect the accuracy of the gage for this reach."

[ngottlieb]

@AWKevin can you clarify (from the Slack discussion) if you do want me to move the correlation comments below the legend or leave them where they are?

I'll add the help text you suggested to the form

[AWKevin]

I think it should for sure be moved to below the graph legend (at a minimum). My open question was whether it should be moved out of the right column entirely and placed under the graph as it used to be. My sense is that some of these comments are lengthy enough that they would make the right column much longer than the graph and lead to a weird presentation on desktop. I am open to either approach.

[AWKevin]

[ngottlieb]

@AWKevin I updated the form with helper text and rearranged the correlation details so it sits on top of both the graph and the level legend — that made sense to me and @riversandcreeks agreed on Slack but curious if you disagree. It's up on beta

[AWKevin]

I like it!

[ngottlieb]

This is live on prod now. There is still a pending investigation into old, missing data via @riversandcreeks and @tallowen