Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate test cases #390

Open
pkra opened this issue Sep 22, 2022 · 5 comments
Open

evaluate test cases #390

pkra opened this issue Sep 22, 2022 · 5 comments
Assignees
Milestone

Comments

@pkra
Copy link
Member

pkra commented Sep 22, 2022

Anything we can do to improve things?

@pkra pkra self-assigned this Sep 22, 2022
@pkra pkra added this to the 2023 milestone Dec 22, 2022
@pkra
Copy link
Member Author

pkra commented Jun 16, 2023

Coverage is lacking for:

  • book-title.js
  • meta-name
  • meta-value
  • subj-group
  • subject

@pkra pkra removed the future label Jun 16, 2023
@pkra
Copy link
Member Author

pkra commented Sep 12, 2023

Two conflicting thoughts:

  • should we refactor our tests to be more unit-test-like? That might ease adding new elements.
  • Should our test sample be generated from TeX via texml? That might more easily catch unexpected changes in texml.

@pkra
Copy link
Member Author

pkra commented Sep 12, 2023

Not using texml to generate our test files risks diverging unintentionally. However, this hasn't been a major problem in the past.

I'm leaning more towards unit-testing because the tests would be easier to understand (and thus maintain). But that would move us even further from a texml-generated approach because texml is too slow to pre-process each snippet.

I suppose we could keep the snippets for the unit tests separately but the XML would just be full of texml-generated boilerplate.

What I'm hoping will happen: if we refactor to unit tests, we'll find which tests are too interconnected. That'll give us a few more complex test cases which we can then generate with texml.

@pkra pkra modified the milestones: 2023, 2024 Jan 15, 2024
@pkra
Copy link
Member Author

pkra commented Jun 3, 2024

#447 makes me want to find time for this.

@pkra
Copy link
Member Author

pkra commented Aug 14, 2024

Random note: perhaps texml's test files could serve as integration/snapshot tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant