Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to safer_owning_ref #409

Open
noamtashma opened this issue Oct 17, 2023 · 2 comments
Open

Migrate to safer_owning_ref #409

noamtashma opened this issue Oct 17, 2023 · 2 comments

Comments

@noamtashma
Copy link

After the maintainer of owning_ref has been unresponsive for a long time, I published my fix of owning_ref known soundness issues as a new crate, safer_owning_ref.

Please migrate to safer_owning_ref.

@bjorn3
Copy link
Contributor

bjorn3 commented Oct 17, 2023

parking_lot doesn't use owning_ref itself. It only has an optional dependency to allow implementing the StableAddress trait of it for the mutex types in case the user wants to use owning_ref. Migrating would break everyone who uses owning_ref with parking_lot mutexes. Having both as optional dependencies would be a possibility though, but I personally don't think safer_owning_ref is nearly as popular for parking_lot to depend on it rather than the other way around. There are several owning_ref alternatives which are way more popular and still maintained like ouroboros and self_cell.

Disclaimer: I'm not a maintainer of this crate.

@noamtashma
Copy link
Author

I see. makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants