Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): positioning #312

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

fbasso
Copy link
Contributor

@fbasso fbasso commented Dec 13, 2023

Enables floating UI positioning.

fix #190

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e25c1a) 91.72% compared to head (ebceafa) 91.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   91.72%   91.83%   +0.11%     
==========================================
  Files          74       74              
  Lines        2078     2083       +5     
  Branches      369      369              
==========================================
+ Hits         1906     1913       +7     
+ Misses        102      100       -2     
  Partials       70       70              
Flag Coverage Δ
e2e-1 61.68% <20.00%> (-0.15%) ⬇️
e2e-2 57.89% <100.00%> (+1.85%) ⬆️
e2e-4 68.80% <33.33%> (-0.12%) ⬇️
e2e-5 69.17% <100.00%> (+1.80%) ⬆️
e2e-7 55.17% <33.33%> (-0.12%) ⬇️
e2e-8 77.11% <100.00%> (+1.33%) ⬆️
unit 90.54% <100.00%> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fbasso fbasso changed the title Select: positioning feat(select): positioning Dec 13, 2023
Copy link
Member

@divdavem divdavem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fbasso for your PR

@divdavem divdavem merged commit 8a8d8a6 into AmadeusITGroup:main Dec 13, 2023
13 checks passed
@fbasso fbasso deleted the select-floating branch December 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select : add positioning with Floating-ui
2 participants