feat(style-bootstrap): slider style refactor + style-bootstrap package #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 78.51% 88.43% +9.91%
==========================================
Files 60 66 +6
Lines 1643 1781 +138
Branches 259 292 +33
==========================================
+ Hits 1290 1575 +285
+ Misses 268 148 -120
+ Partials 85 58 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
divdavem
reviewed
Nov 6, 2023
| [attr.aria-valuenow]="item.value" | ||
| [attr.aria-valuetext]="item.value" | ||
| [attr.disabled]="state().disabled ? true : null" |
There was a problem hiding this comment.
You should not remove the disabled attribute on the <button> element (and you should not add tabindex="-1").
Note that, unlike the disabled attribute, tabindex="-1" does not prevent the ability to focus the button by click.
ValentinNelu
force-pushed
the
feat/slider-css-variables
branch
6 times, most recently
from
e5aecb6 to
85eab3d
Compare
ValentinNelu
force-pushed
the
feat/slider-css-variables
branch
from
85eab3d to
9647023
Compare
divdavem
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.