Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyse if we gonna change how we use blob storage causing memory leak #4899

Closed
9 tasks
TheTechArch opened this issue Sep 30, 2020 · 1 comment
Closed
9 tasks
Labels
kind/user-story Used for issues that describes functionality for our users. skip-releasenotes Issues that do not make sense to list in our release notes

Comments

@TheTechArch
Copy link
Member

TheTechArch commented Sep 30, 2020

Description

It has been identified that instansiating new CloudBlobClients can cause memoryleaks for Application Insight
microsoft/ApplicationInsights-dotnet#1867 (comment)

We experience memory leaks for ApplicationInsight and we do the same in storage component.

We should look in to if we can rewrite our code to reduce the problem. A 100% fix would require fix from MS.

See datarepository
https://github.com/Altinn/altinn-studio/blob/master/src/Altinn.Platform/Altinn.Platform.Storage/Storage/Repository/DataRepository.cs

Considerations

  • We use different blob accounts depending on the service owner. We can not create on shared client. We would need serveral.

Acceptance criteria

Describe criteria here (i.e. What is allowed/not allowed (negative tesing), validations, error messages and warnings etc.)

Specification tasks

  • Development tasks are defined
  • Test design / decide test need

Development tasks

Add tasks here

Definition of done

Verify that this issue meets DoD (Only for project members) before closing.

  • Documentation is updated (if relevant)
    • Technical documentation (docs.altinn.studio)
    • User documentation (altinn.github.io/docs)
  • QA
  • Manual test is complete (if relevant)
  • Automated test is implemented (if relevant)
  • All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)
@TheTechArch TheTechArch added the kind/user-story Used for issues that describes functionality for our users. label Sep 30, 2020
@lvbachmann lvbachmann changed the title Analyse if we gonna change how we use blog storage causing memory leak Analyse if we gonna change how we use blob storage causing memory leak Oct 8, 2021
@TheTechArch
Copy link
Member Author

We dont have any konen issue with this

@SandGrainOne SandGrainOne added the skip-releasenotes Issues that do not make sense to list in our release notes label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users. skip-releasenotes Issues that do not make sense to list in our release notes
Projects
None yet
Development

No branches or pull requests

2 participants