Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change iconName to icon #234

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: change iconName to icon #234

merged 1 commit into from
Feb 6, 2025

Conversation

seanes
Copy link
Collaborator

@seanes seanes commented Feb 3, 2025

Before:

npm notice name: @altinn/altinn-components
npm notice version: 0.15.5
npm notice filename: altinn-altinn-components-0.15.5.tgz
npm notice package size: 163.1 kB
npm notice unpacked size: 1.3 MB
npm notice shasum: 74120c478a305630ef81f45dff1e5d434bfa5f74
npm notice integrity: sha512-C0GFI2fNx+ZQq[...]pUIJxDJbtAmSA==
npm notice total files: 813

Before:

npm notice name: @altinn/altinn-components
npm notice version: 0.15.4
npm notice filename: altinn-altinn-components-0.15.4.tgz
npm notice package size: 289.1 kB
npm notice unpacked size: 2.6 MB
npm notice shasum: 0c70e75717acca21582535858b806b32dc72676f
npm notice integrity: sha512-fhlBMSive10x0[...]Rnas3bpuPSBiA==
npm notice total files: 800

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@seanes seanes force-pushed the refactor_iconnames branch 5 times, most recently from 33736bc to 9be7b30 Compare February 3, 2025 17:02
@seanes seanes requested review from mbacherycz and allinox February 3, 2025 17:07
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit this isn't my most thorough QA, but what I've seen from the code and testing in storybook looks good to me 😊
Great work! 🙌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky, but this documentation on how to use the component should probably be updated to using the new icon system
image

@seanes seanes force-pushed the refactor_iconnames branch from 9be7b30 to 763c7c7 Compare February 6, 2025 07:43
@seanes seanes force-pushed the refactor_iconnames branch from 763c7c7 to 82f035b Compare February 6, 2025 07:47
@seanes seanes merged commit c8c357b into main Feb 6, 2025
4 checks passed
@seanes seanes deleted the refactor_iconnames branch February 6, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants