feat: fe error boundary #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corquaid
reviewed
Jul 8, 2022
| /** | ||
| * Catches the app exceptions. | ||
| * | ||
| * This implementation tries to NOT depend on anything, ie. styled-components and themes. |
There was a problem hiding this comment.
How does work for locales / i18n? Just hard-coded English text for now?
There was a problem hiding this comment.
Yes, I made this decision to minimise the number of dependencies. Now, not using locales is not a real case for us, because it's just plain object, but if any i18n will be added, then I think it's still good to not be dependent on specific library.
tarnas14
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ErrorBoundary intercepts the app exceptions, and shows the error message to the user.
TODO in next PR(s):
Motivation and Context
Show error to the user instead of crashing the app.
How Has This Been Tested?