Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Plots for "open" review #69

Open
XylotrupesGideon opened this issue Jan 12, 2022 · 2 comments
Open

[Feature] - Plots for "open" review #69

XylotrupesGideon opened this issue Jan 12, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@XylotrupesGideon
Copy link

This is a low priority feature.
When the plot system opens up to be used by multiple teams at the same time it we will have a large pool of reviewers that could help out in cases where suddenly a lot of people want to join a specific team and the teams own reviewers get overwhelmed.
Therefore I propose that teams get the option to open thier plots for "open review" so that reviewers from other teams can help out.
Either the teams could set a maximum queue length before additional plots gets automatically added to the open review queue or they could set a certain difficulty level or other criterium for plots to be set to the open review queue... e.g. a team could set it in a way that the teams own reviewer have to check the first 3 builds by a new builder but after that (when the builder has proven the basic ability to build) all further builds from this builder could be adde to the open review queue so they get reviewed faster.

This would make the review process quicker and would make sure that builds could be reviewed in all time zones. Of course the Build team would need to have options to adjust this system to their desire depending on how much they trust the reviweing teams from the other Build teams.

Some ideas for options summed up

  • maximum review queue length
  • review timer (e.g. if a plot has not been reviewed in 24h)
  • number of already reviewed builds by this builder (or builder score)
  • completeted builds for other build teams (when a buidler joins in from a different team)
  • difficulty level
  • custom tags for plots that can be reviewed by other reviewers or that need to be reviewed by the same team
@XylotrupesGideon XylotrupesGideon added the enhancement New feature or request label Jan 12, 2022
@Cinnazeyy
Copy link
Member

I really like your idea!
We will probably be working on an easier more stripped down version first though, since that does sound quite complex and ambitious.
What do you think of black- or whitelists of teams that are able to review for you?
Alternatively we could also just use a single setting for either enabling or disabling review by everyone.
(I am trying to lean away from plot-specific things for now since that would probably require some reworking on the database)

@XylotrupesGideon
Copy link
Author

Sure, i think it is more of an edge case any way most of the time a few reviewers willb e able to handl the review of plots themselves. It might be a case where we first have to see how it works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants