Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to remove trades more accurately by their output ItemStack #16

Closed
lonevox opened this issue Jun 29, 2024 · 1 comment
Closed

Comments

@lonevox
Copy link

lonevox commented Jun 29, 2024

Describe the feature/addition!

Trades don't exactly have anything that identifies them, but if you could remove a trade from the output ItemStack that would be much preferred for my use case than removing all trades of a certain level. I guess this would still remove all trades with that output stack, but this is a more accurate way than what is currently available.

Why would like to see this feature/addition?

Removing all trades of a certain level removes some trades that I don't actually want to remove. I can add them back but I think it would be cleaner if you could specify the output ItemStack for more fine-grained control.

@LLytho
Copy link
Member

LLytho commented Jun 29, 2024

There is already a way to remove stuff by a TradeFilter but it's not fully fleshed out. There are examples in the discord for this, you can lookup there for more information.

@LLytho LLytho closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants