Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split panes for text, table and tree view #193

Closed
grayswandyr opened this issue Jan 24, 2023 · 6 comments
Closed

Add split panes for text, table and tree view #193

grayswandyr opened this issue Jan 24, 2023 · 6 comments
Assignees
Milestone

Comments

@grayswandyr
Copy link
Contributor

Currently we have a split view for the graphical depiction of consecutive states in the Visualizer, but not for the text, table and tree views. Diff-like colors would even be nice in these views (at least the text one).

@nmacedo
Copy link
Contributor

nmacedo commented Apr 14, 2023

Very basic implementation for text and table views for 6.2:
Screenshot 2023-04-14 at 19 10 59
Screenshot 2023-04-14 at 19 10 49

@grayswandyr
Copy link
Contributor Author

@nmacedo thank you so much, you rock!
Can you point me to the commit implementing this?

@pkriens
Copy link
Contributor

pkriens commented Apr 15, 2023

This great! I can adapt the drawings of the box to use constant vertical space & ordering so the stay on the same place.

@nmacedo
Copy link
Contributor

nmacedo commented Apr 15, 2023

@nmacedo thank you so much, you rock! Can you point me to the commit implementing this?

It's here. It's nothing fancy, it just tests if the line/table was present in the previous state.

@grayswandyr
Copy link
Contributor Author

  • When a piece of highlighted text is selected, its color doesn't change. After a quick web search, it seems like there's a way to make selection of highlighted text visible...?
  • The diff could be finer-grained by only highlighting added and removed atoms (in red and green, à la git diff). I could implement a diffing algorithm returning the list of added and removed atoms per relation; however I think it'd be better to pass valuations rather than strings as parameters (I just need to know what Java type has been defined for valuations in Alloy?).

@nmacedo
Copy link
Contributor

nmacedo commented May 2, 2023

  • When a piece of highlighted text is selected, its color doesn't change. After a quick web search, it seems like there's a way to make selection of highlighted text visible...?

I'll look into it.

  • The diff could be finer-grained by only highlighting added and removed atoms (in red and green, à la git diff). I could implement a diffing algorithm returning the list of added and removed atoms per relation; however I think it'd be better to pass valuations rather than strings as parameters (I just need to know what Java type has been defined for valuations in Alloy?).

That would be great, but would require changing the code a bit. Currently the text/table views don't really store any information about the instance, they are just passed a string to be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants