Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nwb_reader #286

Closed
wbwakeman opened this issue Oct 15, 2019 · 1 comment
Closed

Refactor nwb_reader #286

wbwakeman opened this issue Oct 15, 2019 · 1 comment

Comments

@wbwakeman
Copy link

wbwakeman commented Oct 15, 2019

Refactor nwb_reader to be based on version of nwb rather than mix of nwb version and the pipeline version.
Currently there are 3 nwb reader classes:
NwbXreader for reading nwb2 files
NwbPipelineReader for reading nwb1 files produced by pipeline
NwbMiesReader for reading Mies generated nwb file

These support AibsDataSet(nwb1) and HBGDataSet (nwb2) objects
The relationship between DataSet classes and nwb reader classes is not confusing. As we are moving to nwb2, AibsDataSet should support nwb2 files as well.

Need design DataSet classes and readers such to support MIES or non MIES nwb both for nwb1 and nwb2 plus give some consideration for different version of nwb1/pipeline

Completed:
Designed refactor
Refactored all classes

Remaining:
integrate individual components and ensure tests run successfully (8) (resolve any problems that arise)
write additional tests for new classes (HBGNWBData, MIESNWEBData, EphysDataSetClass) (5)
Deprecate older classes, functionality and tests (5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants