Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new hdmf version breaks pynwb #2098

Closed
4 tasks
djkapner opened this issue Apr 23, 2021 · 2 comments · Fixed by #2099
Closed
4 tasks

new hdmf version breaks pynwb #2098

djkapner opened this issue Apr 23, 2021 · 2 comments · Fixed by #2099
Assignees
Labels
braintv relates to Insitute BrainTV program

Comments

@djkapner
Copy link
Contributor

djkapner commented Apr 23, 2021

@dougollerenshaw found this this evening:
a fresh install will pull down hdmf 2.5.0. This breaks pynwb/allensdk in some ways.

Tasks:

  • add an hdmf<=2.4.0 to requirements.txt
  • make that change in master, roll a minor release
  • rebase rc/2.11.0
  • contact pynwb

To reproduce, in a fresh env:

>>> from allensdk.brain_observatory.behavior.session_apis.data_io import BehaviorLimsApi
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/danielk/repos/AllenSDK/allensdk/brain_observatory/behavior/session_apis/data_io/__init__.py", line 6, in <module>
    from allensdk.brain_observatory.behavior.session_apis.data_io.behavior_nwb_api import BehaviorNwbApi  # noqa: F401, E501
  File "/home/danielk/repos/AllenSDK/allensdk/brain_observatory/behavior/session_apis/data_io/behavior_nwb_api.py", line 11, in <module>
    import allensdk.brain_observatory.nwb as nwb
  File "/home/danielk/repos/AllenSDK/allensdk/brain_observatory/nwb/__init__.py", line 21, in <module>
    from allensdk.brain_observatory.behavior.write_nwb.extensions.stimulus_template.ndx_stimulus_template import StimulusTemplateExtension  # noqa: E501
  File "/home/danielk/repos/AllenSDK/allensdk/brain_observatory/behavior/write_nwb/extensions/stimulus_template/ndx_stimulus_template.py", line 15, in <module>
    'ndx-aibs-stimulus-template')
  File "/home/danielk/miniconda3/envs/test/lib/python3.7/site-packages/hdmf/utils.py", line 584, in func_call
    return func(**pargs)
  File "/home/danielk/miniconda3/envs/test/lib/python3.7/site-packages/pynwb/__init__.py", line 187, in get_class
    return __TYPE_MAP.get_container_cls(namespace, neurodata_type)
  File "/home/danielk/miniconda3/envs/test/lib/python3.7/site-packages/hdmf/utils.py", line 580, in func_call
    return func(args[0], **pargs)
  File "/home/danielk/miniconda3/envs/test/lib/python3.7/site-packages/hdmf/build/manager.py", line 506, in get_container_cls
    spec = self.__ns_catalog.get_spec(namespace, data_type)
  File "/home/danielk/miniconda3/envs/test/lib/python3.7/site-packages/hdmf/utils.py", line 580, in func_call
    return func(args[0], **pargs)
  File "/home/danielk/miniconda3/envs/test/lib/python3.7/site-packages/hdmf/spec/namespace.py", line 316, in get_spec
    raise KeyError("'%s' not a namespace" % namespace)
KeyError: "'StimulusTemplate' not a namespace"
@rly
Copy link

rly commented Apr 23, 2021

Sorry about that. We are working on a release to pynwb to account for the change and we plan to release it tomorrow morning. PyNWB will then pin a particular version of hdmf to prevent these incompatibilities in the future.

@rly
Copy link

rly commented Apr 23, 2021

FYI: The PyNWB/HDMF team have released HDMF 2.5.1 on PyPI and conda-forge. This release reverts the breaking change. We have yanked HDMF 2.5.0 from PyPI and are in the process of marking it as broken in conda-forge. Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
braintv relates to Insitute BrainTV program
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants