Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainthread: support windows #764

Open
gucio321 opened this issue Feb 18, 2024 · 3 comments
Open

mainthread: support windows #764

gucio321 opened this issue Feb 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@gucio321
Copy link
Collaborator

We use mainthread libraries to allow giu commands on any thread (when imgui requires to run on main)

We currently have implementations for macos and linux but for windows none works.

@gucio321 gucio321 added the enhancement New feature or request label Feb 18, 2024
@gucio321
Copy link
Collaborator Author

hmm, well, when I look at it @AllenDang why are we using this miainthread in fact?
Am I right above?

@AllenDang
Copy link
Owner

AllenDang commented Feb 19, 2024

As I remember, OpenGL requires to run GPU related operations in the main thread, so I use mainthread to archive that.
And at that time, I'm using golang wrapper of glfw to write a backend manually, which works great on linux/Mac/windows, for now, we are using glfw backend directly from Imgui right? Maybe we don't need mainthread anymore? Like the backend example in cimgui shows.

@gucio321
Copy link
Collaborator Author

so in fact we just need to call NewMasterWindow in the same thread as Run, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants