Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colony mask training/inference instructions #27

Open
mfs4rd opened this issue Oct 22, 2024 · 1 comment
Open

Colony mask training/inference instructions #27

mfs4rd opened this issue Oct 22, 2024 · 1 comment
Assignees

Comments

@mfs4rd
Copy link
Collaborator

mfs4rd commented Oct 22, 2024

This issue is about the work-in-progress branch for colony mask inference reproducibility, sm_colony_mask_pred_test_v0.

Report on improvements for the all colony mask inference repo instructions

  1. Make clearer in step 1 that the data directory should be a subdirectory of Colony_mask_training_inference earlier in the step

  2. Attempting to pip install . the repo when data directory is present causes issues where pip believes it is a module directory. Consider adding a setting in the setup files to prevent this

  3. the way the paths/default.yaml file is set up doesn't check the folder the repo has been cloned into, or CYTODL_CONFIG_PATH=$PWD/configs does not work as intended

  4. eval_scale*.yaml files have predict_all_cells_mask_zarr_aws_v0.csv as the default csv file, but predict_all_cells_mask_v0.csv is the one currently provided. You will likely be changing this for the final release but make sure the default matches then

@pgarrison
Copy link
Collaborator

pgarrison commented Oct 22, 2024

Love this! Thanks @mfs4rd

  1. is partially captured in Colony mask inference pip install . may fail #25. I've added it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants