-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect manifest for Nuclei_localization.py #7
Comments
Strange, we already have |
Related bioio-devs/bioio-ome-zarr#28 |
Okay, I went down the wrong path: it's not a dependency issue, it's that there is no image at Investigation questions
Resolution tasks
Post-mortem questions
|
@smishra3 we need your eye on this. |
I double checked and there is no basement membrane segmentation for this id 3500005827_9. 3500005827_9 has a fms-id - 08d16b7278e24a5c8cdf8c3f723f4859. Goutham has never generated segmentations for this fms id. I also checked the parent directory and it's not there either (\allen\aics\assay-dev\computational\data\EMT_deliverable_processing\Collagen_segmentation_segmentations). I saw it's in the manifest. Checking now what's the issue. |
@niveditasa do you know if this movie was ever analyzed? |
I found the bug. At present s3://allencell/aics/emt_timelapse_dataset/data/3500005827_20_collagenIV_segmentation_probability.ome.zarr exists but not included in the manifest, and s3://allencell/aics/emt_timelapse_dataset/data/3500005827_9_collagenIV_segmentation_probability.ome.zarr doesn't exist and is included in the manifest. |
@pgarrison can you rerun your test on this updated manifest? Only the rows containing 3500005827_9 and 3500005827_20 have been changed to fix the bug. |
@smishra3 Are you saying that the segmentations uploaded are correct and it's just the manifest that is off? So we are not expected to have a basement membrane segmentation for 3500005827_9, and we are supposed to have one for 3500005827_20? |
@pgarrison Exactly. Collagen IV for 3500005827_9 is never done and is also not expected to be done either as 3500005827_9 is a 2D colony. In the paper and in current work and analysis, no collagenIV segmentation is done for a 2D colony (all membrane segmentations are for 3D colonies). It's a naming issue. And I'm not sure how it got overlooked. When I tried the web viewer link (of the collagenIV and the combined), the link were also dead. I had an opinion that all links were tested. With changing the naming you can now see the web viewer links are also working. |
The following root cause diagnosis is summarized from an in-person discussion with @smishra3. Root causeThere are 3 tightly related errors in the manifest:
The two affected movies, How our data validation steps failed to catch it
|
@smishra3 @mfs4rd I successfully ran the |
@pgarrison The localization code is identical to what was used for the data/results published aside from the changes needed to be compatible with s3 storage by downloading the files to a local directory, and @smishra3 @antoineborensztejn and I verified that the meshes on s3 are identical to the originals. I don't think there is anything else that needs to be validated atm. |
When I run
Nuclei_localization.py
I get the following error.The text was updated successfully, but these errors were encountered: